Compare the Tuesday forecast winds in Toyko on the Weather Channel with this link

http://www.weather.com/outlook/travel/b ... 5?dayNum=1

with the fixed skin at the Daily Forecast screen

http://webpages.charter.net/david1970/MarmolEn.zip

It's now correct.

Now compare the weather.com link with any other skin.

There will be a bug.

The same is true with anywhere.

David

The key is the variable in current.wtp

DAILY WIND FULL NIGHT is the variable that contains the wind direction and speed. When used in daily.wtp, it gives the correct reading in there too. Trying to seperate the night wind direction from the night wind speed will produce a bug.

To prove my point, go to a city that has N/A for Monday afternoon, such as Baghdad, Iraq, using any skin other than barba'a/

The night wind shows the wind direction as N/A in all skins.

Why?

Because it copied the value of the N/A of Monday afternoon.

The night wind should be NNW, according to both the Weather Channel and Barba's fixed skin.

David

P.S. Babra, you posted a copy of an old version of the skin. You need to download a fresh copy.

The following changes have been made to the skin.

The wind direction has been fixed in daily forecast screen.

The wind direction has been added to the daily and hourly forecast at the botttom of the current conditions screen. Just place your mouse over the day tab.

Sunrise and Sunset data has been added to the daily forecast at the current conditions screen.

By the way, if you see the earliest day at the bottom of the current conditions screen aay "N/A", that is not a bug. I did it for the sake of those who do not like the scolling ticker, such as my Mom. Now they can simply put the mouse over the day tab and get the forecast.

David

Download at http://webpages.charter.net/david1970/MarmolEn.zip

David

I've checked all the data in this skin and compared it to weather.com in several cities, and it all agreed with weather.com

This skin is bug-free. I've put in all the weather information the variables in current.wtp will let me put in. I'm done working on it. I hope that barba appreciates my work.

If you have any suggestions on how to improve the skin, please let me know.

I hope that everyone will enjoy using the skin.

It's been a labor of love, and it was really a joy to work on it.

You can download the final version at

http://webpages.charter.net/david1970/MarmolEn.zip


David

Fixed it wind direction

http://ar.geocities.com/barba_roar/ww/MarmolEn.zip

Versi?n en espa?ol Corregido la direcci?n del viento

http://ar.geocities.com/barba_roar/ww/MarmolEs.zip

Hugs

Since you asked, I have two suggestions;

1. post an image of what your skin looks like so visitors can determine whether it appeals to them or not. Thus they don't have to download it, and overlay barba's version, only to find they don't like it.

2. rename your version to something like "Daves Marmol(english)". Thus visitors can have both versions. It's one thing to fix a bug in someone's skin and keep it's name, but you have gone beyond that and made changes that appeal to you (and mom ) but may not appeal to the original author or that the original author may not wish to maintain. It's the same approach I and others have done with Mike's Splendid skin.

3. If you have used ideas and code from other skins posted here add comments in your code indicating where it was copied from or who's idea it is based on thus acknowledging the work others have contributed to your creation.

Barba,

Your version of the skin had a bug that caused the scrolling ticker not to show correct sunrise and sunset data. It was off by a minute or two. I fixed the error. Other than that, you did a great job with the skin, especially with the wind direction arrows!

Attached is the fixed skin. Other than fixing the bug, it is the same one you posted on the forum.

http:://webpages.charter.net/david1970/MarmolEn.zip

i did not find the bug that you say.
please show me in which place of the program is.
I do not know if it is understood what I wrote
I not speak english

The sunrise and sunset times on the daily forecast screen and at the bottom of the current condition screen are correct. I compared that page to weather.com for several cities, and indeed they are corrent. However, the scrollng ticker is off by one minute, sometimes it is sunrise, sometimes it is sunset.

The problem is that you have [SUNRISE AMPM] and [SUNSET AMPM] in current.wtp and [DAILY SUNRISE AMPM] and [DAILY SUNSET AMPM] further down at current.wtp.

You need to change [SUNRISE AMPM] and [SUNSET AMPM]. Call it [DAILY SUNRISE AMPM] and [DAILY SUNSET AMPM].

I tried changing everything to [SUNRISE AMPM] and [SUNSET AMPM], but Weather Watcher refused to change the times for each day. I know that Ed will come along and say it doesn't make a difference, but the program is very picky about this.

Once I changed everything to [DAILY SUNRISE AMPM] and [DAILY SUNSET AMPM], everything was working correctly.

David

Barba, I have the bug already fixed here

http://webpages.charter.net/david1970/MarmolEn.zip

I have made NO FURTHER CHANGES except to get rid of the bug.




Ed, I apologize if I offended anyone. I guess I got carried away. The only person whose code I copied was from your Stone Soup. I gave you credit on this message board, but didn't realize it needed to be in the code too. Remember, I have done nothing like this before, so everything is really new to me. As for the code of the changing of the moon 180 degrees, that was all done by Barba, not me. Like you, I had no idea that the moon rotated 180 degrees in the southern hemisphere. The only difference between my last revision and Barba's new version of Marmol is that he put a red O where I had "moon option", so there is no need to make my own Marmol. I will make no further changes other than to fix bugs, like I did this morning.

I'm sorry if I caused any trouble.

David

You didn't offend, we/I understand your enthusiasm, and in fact it is contagious and we have all benefited from it. I was just trying to help you finish up this project, tie up loose ends and to prepare you for the next one.

Barba,

I found a bug on the Daily Forecast Screen.


I fixed it.


When ever there was a night calm wind in the daily forecast, it would make a broken graphic.


Here is the correction that I made:





<SCRIPT TYPE="text/javascript" LANGUAGE="JavaScript">var oest = '[DAILY WIND FULL NIGHT]';if ((oest.substr(0,3)) === "NNW" ||(oest.substr(0,3)) === "NNE" ||(oest.substr(0,3)) === "ENE" ||(oest.substr(0,3)) === "ESE" || (oest.substr(0,3)) === "SSE" ||(oest.substr(0,3)) === "SSW" ||(oest.substr(0,3)) === "WSW" ||(oest.substr(0,3)) === "WNW") { var wind = (oest.substr(0,3)); } else {if ((oest.substr(0,2)) === "NW" ||(oest.substr(0,2)) === "NE" || (oest.substr(0,2)) === "SE" || (oest.substr(0,2)) === "SW") { var wind = (oest.substr(0,2)); } else {if ((oest.substr(0,1)) === "N" ||(oest.substr(0,1)) === "E" ||(oest.substr(0,1)) === "S" ||(oest.substr(0,1)) === "W") { var wind = (oest.substr(0,1)); } else { var wind = (oest.substr(0,4));}}};
document.write("<TD ALIGN='center' CLASS='TDTanDark'ID='BorderLeft' VALIGN='middle' NOWRAP ><IMG SRC='Images/WindSmall/"+wind+".gif'><BR>"+oest+"</TD>");</SCRIPT>






If this all sounds confusing, take my word for it, it has been fixed.

You can download the fixed skin at
http://webpages.charter.net/david1970/MarmolEn.zip


David

David, do you remember my saying to test all changes for 24 hrs before posting?

As for your fix wouldn't testing one of the numerous WIND tags for the value 0 k/mh be easier, or adding a new wind graphic?

Ed,

I used the zipcode 23434 (my hometown), then went to the daily forecast screen. There were a couple of CALM nights, and above them were broken graphics. The rest of the arrows on the screen were correct. I went into daily.wtp and saw that he had the 3-letter, 2-letter, and 1-letter wind directions programmed in, but he did not have code for a 4-letter abbreviation (CALM) . I wrote that code, then went back into 23434. All arrows were correct, the CALM entries had no arrow and no broken graphic (like it should).

I wrote the code correctly. There may be other bugs in the skin, but the latest bug has been fixed. I apologize for not waiting 24 hours, but hopefully that is the last of the bugs. I know current.wtp has no bugs, as I already had tested that yesterday, the only change that Barba made was put a different options.jpg file in the images folder. I tested the hourly and detailed forecasts yesterday and they came back bug-free. The only change that Barba made was in the daily.wtp file, and that was with the wind arrows. All the nightly arrows are now working, as I have selected several cities, and viewed all wind directions.

Again, sorry for upsetting you.

David